FM Design
Would you like to react to this message? Create an account in a few clicks or log in to continue.

IMPORTANT

FM Design is in read-only mode, please click here for more information.

Latest topics
» Forumactif Edge - Releases
by Ange Tuteur Tue 03 Sep 2019, 11:49

» GIFActif - Giphy Button for the Editor
by Ange Tuteur Wed 08 May 2019, 17:21

» Forum Closure
by Ange Tuteur Mon 01 Jan 2018, 01:28

» Chit Chat Thread
by Valoish Sun 31 Dec 2017, 19:15

» Font/Text background color.
by Valoish Sun 31 Dec 2017, 19:11

» Forumactif Messenger - Instant Message Application for Forumotion
by Wolfuryo Sun 31 Dec 2017, 18:24

» [GAME] Count to One Million!
by brandon_g Fri 29 Dec 2017, 18:58

» Post Cards
by manikbiradar Wed 20 Dec 2017, 07:50

» [GAME] Countdown from 200,000
by Valoish Wed 13 Dec 2017, 23:22

» GeekPolice Tech Support Forums - GeekPolice.net
by Dr Jay Mon 11 Dec 2017, 19:12

» Asking about some plugin for Forumotion
by Dr Jay Mon 11 Dec 2017, 19:10

» [GAME] What are you thinking right now?
by Van-Helsing Sat 09 Dec 2017, 14:51

» Widget : Similar topics
by ranbac Wed 06 Dec 2017, 18:11

» Change the Background of the Forum and put an image and how to make prefixs?
by Clement Wed 06 Dec 2017, 15:19

» Hello from Western Australia
by SarkZKalie Wed 06 Dec 2017, 05:34

Recent Tutorials
Top posting users this month

Who is online?
In total there are 5 users online :: 0 Registered, 0 Hidden and 5 Guests :: 2 Bots

None

[ View the whole list ]


Most users ever online was 515 on Tue 14 Sep 2021, 15:24

Adding text to reputation counter

View previous topic View next topic Go down

Laura
Laura
New Member
Gender : Unspecified
Posts : 6
Points : 2831
Reputation : 4
Language : Spanish, Catalan, English
Browser : Browser : Google Chrome Forum Version : Forum Version : Forumactif Edge

PostLaura Wed 22 Mar 2017, 05:30

Hi!

First, I'm not too sure this was the right place to post, my apologies if this topic shouldn't go here. Embarassed

What I'm trying to do is add a text to the reputation counter, so that it looks like this before voting:

Adding text to reputation counter NoVotes

And like this once you have:

Adding text to reputation counter Voted

(I have removed the thumbs down option as well as the vote bar with CSS).

I tried just adding the string to the JS, like this:

Code:

$(function(){
  for (var vote = $('.vote'), i = 0, j = vote.length, bar, total, percent, n_pos, n_neg; i < j; i++) {
    bar = $('.vote-bar', vote[i])[0];

    if (bar) {
      total = +bar.title.replace(/.*?\((\d+).*/, '$1');
      percent = +bar.title.replace(/.*?(\d+)%.*/, '$1');

      n_pos = Math.round(total * (percent / 100));
      n_neg = total - n_pos;
    } else {
      n_pos = 0;
      n_neg = 0;
    }

    vote[i].insertAdjacentHTML('afterbegin', '<span class="vote_num vote_good">' + n_pos + ' me gusta ' + '</span>');
    vote[i].insertAdjacentHTML('beforeend', '<span class="vote_num vote_bad">' + n_neg + '</span>');

    $('a', vote[i]).click(function() {
      var that = this,
          links = $('a', that.parentNode);

      $.get(that.href, function() {
        var n = that[/minus/.test(that.className) ? 'nextSibling' : 'previousSibling'];
        n.innerHTML = ++n.innerHTML;
        links.fadeOut();
      });


      links.attr('href', '#').css({
        opacity : 0.4,
        cursor : 'default'
      });

      return false;
    });
  }
});

But it seems it's not enough, as right now it does display the text, but the vote counter doesn't update properly. Once it's clicked, instead of showing the counter with the text, NaN appears (refreshing the page, though, makes the number of votes and text display correctly again).

Adding text to reputation counter Clicked

Could anyone help me out with this, please? Thanks in advance! Smile


Last edited by Laura on Thu 23 Mar 2017, 16:55; edited 1 time in total
Ange Tuteur
Ange Tuteur
Administrator
Gender : Male
Posts : 4741
Points : 12257
Reputation : 2376
Location : Pennsylvania
Language : EN, JA, FR
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
https://sethclydesdale.github.io/ https://twitter.com/sethc1995

PostAnge Tuteur Wed 22 Mar 2017, 17:14

Hi @Laura,

It's displaying NaN ( Not a Number ), because when the script adds the votes to .vote_num.vote_good it does some math on the innerHTML content, and since there's non-numerical text inside the element it returns NaN. Here's a quick example :
Code:
+'Hello' == NaN // Hello cannot be converted to a number
+'1' == 1 // the string is converted to a number

Here's the corrected script :
Code:
 
$(function(){
  for (var vote = $('.vote'), i = 0, j = vote.length, bar, total, percent, n_pos, n_neg; i < j; i++) {
    bar = $('.vote-bar', vote[i])[0];
 
    if (bar) {
      total = +bar.title.replace(/.*?\((\d+).*/, '$1');
      percent = +bar.title.replace(/.*?(\d+)%.*/, '$1');
 
      n_pos = Math.round(total * (percent / 100));
      n_neg = total - n_pos;
    } else {
      n_pos = 0;
      n_neg = 0;
    }
 
    vote[i].insertAdjacentHTML('afterbegin', '<span class="vote_num vote_good">' + n_pos + '</span><span class="vote_good"> me gusta </span>');
    vote[i].insertAdjacentHTML('beforeend', '<span class="vote_num vote_bad">' + n_neg + '</span>');
 
    $('a', vote[i]).click(function() {
      var that = this,
          links = $('a', that.parentNode);
 
      $.get(that.href, function() {
        var n = that[/minus/.test(that.className) ? 'nextSibling' : 'previousSibling'];
        n.previousSibling.innerHTML = ++n.innerHTML;
        links.fadeOut();
      });
 
 
      links.attr('href', '#').css({
        opacity : 0.4,
        cursor : 'default'
      });
 
      return false;
    });
  }
});
I added the texts to a new separate tag, and added an extra step back in the node list. Let me know if it works okay for you. Wink
Laura
Laura
New Member
Gender : Unspecified
Posts : 6
Points : 2831
Reputation : 4
Language : Spanish, Catalan, English
Browser : Browser : Google Chrome Forum Version : Forum Version : Forumactif Edge

PostLaura Thu 23 Mar 2017, 02:49

Hi, @Ange Tuteur,

Thank you so much for taking the time to help me. Smile

I've switched to your code and here's what I'm getting now:

Adding text to reputation counter NaN
Ange Tuteur
Ange Tuteur
Administrator
Gender : Male
Posts : 4741
Points : 12257
Reputation : 2376
Location : Pennsylvania
Language : EN, JA, FR
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
https://sethclydesdale.github.io/ https://twitter.com/sethc1995

PostAnge Tuteur Thu 23 Mar 2017, 16:17

Whoops I frogot to add previousSibling to the increment. Face palm Try now :
Code:
$(function(){
  for (var vote = $('.vote'), i = 0, j = vote.length, bar, total, percent, n_pos, n_neg; i < j; i++) {
    bar = $('.vote-bar', vote[i])[0];

    if (bar) {
      total = +bar.title.replace(/.*?\((\d+).*/, '$1');
      percent = +bar.title.replace(/.*?(\d+)%.*/, '$1');

      n_pos = Math.round(total * (percent / 100));
      n_neg = total - n_pos;
    } else {
      n_pos = 0;
      n_neg = 0;
    }

    vote[i].insertAdjacentHTML('afterbegin', '<span class="vote_num vote_good">' + n_pos + '</span><span class="vote_good"> me gusta </span>');
    vote[i].insertAdjacentHTML('beforeend', '<span class="vote_num vote_bad">' + n_neg + '</span>');

    $('a', vote[i]).click(function() {
      var that = this,
          links = $('a', that.parentNode);

      $.get(that.href, function() {
        var n = that[/minus/.test(that.className) ? 'nextSibling' : 'previousSibling'].previousSibling;
        n.innerHTML = ++n.innerHTML;
        links.fadeOut();
      });


      links.attr('href', '#').css({
        opacity : 0.4,
        cursor : 'default'
      });

      return false;
    });
  }
});
Laura
Laura
New Member
Gender : Unspecified
Posts : 6
Points : 2831
Reputation : 4
Language : Spanish, Catalan, English
Browser : Browser : Google Chrome Forum Version : Forum Version : Forumactif Edge

PostLaura Thu 23 Mar 2017, 16:55

That worked! Thank you so much, @Ange Tuteur! Very Happy
Ange Tuteur
Ange Tuteur
Administrator
Gender : Male
Posts : 4741
Points : 12257
Reputation : 2376
Location : Pennsylvania
Language : EN, JA, FR
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
https://sethclydesdale.github.io/ https://twitter.com/sethc1995

PostAnge Tuteur Thu 23 Mar 2017, 17:19

You're welcome ! ^^
Sponsored content

PostSponsored content

View previous topic View next topic Back to top

Create an account or log in to leave a reply

You need to be a member in order to leave a reply.

Create an account

Join our community by creating a new account. It's easy!


Create a new account

Log in

Already have an account? No problem, log in here.


Log in

 
Permissions in this forum:
You cannot reply to topics in this forum