Recent Tutorials
Who is online?
In total there are 6 users online :: 2 Registered, 0 Hidden and 4 Guests

djblah, SLGray

[ View the whole list ]


Most users ever online was 172 on Fri 19 Feb 2016, 05:17

Upgraded characters updated

View previous topic View next topic Go down

avatar
Milouze14

Title :
Gender : Male
Age : 51
Posts : 76
Points : 418
Reputation : 22
Location : French Vendée
Language : French
Browser : Browser : Mozilla Firefox Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile http://www.milouze14.com/

PostMilouze14 on Tue 04 Apr 2017, 10:42

Hello @Ange Tuteur cheers ,

I encounter worries with every update concerning the French language, the accents (on the letters to, é and è) I am obliged every time to return to the scripts to correct them, I want to clarify that My fofo is almost twelve years old.

So I find myself with characters A or something like it

Can this be corrected please?

thank you very much Wink .

a++
avatar
Ange Tuteur
Administrator
Title :
Coffee Addict
Gender : Male
Age : 21
Posts : 4675
Points : 9689
Reputation : 2331
Location : Macungie, PA
Language : EN10, FR5
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile https://github.com/SethClydesdale https://twitter.com/sethc1995

PostAnge Tuteur on Fri 07 Apr 2017, 11:43

Hi @Milouze14,

Thanks for reporting this. I've dealt with an issue similar to this back on the English Support Forum when I was implementing functionalities that used AJAX. The support forum's document character set is windows-1252 and I'm assuming that's what your forum's character set is as well. Anyways, on this charset ( and I think ISO charsets ) performing AJAX encodes the characters in UTF8 which corrupts the ISO and Windows characters, usually giving you "Á" and such. Luckily I still have the encoding function I wrote for the support forum, so I'm going to try and integrate that into FAE's core AJAX functions so we can avoid corrupting older forum's characters.

@Dr Jay I think Geek Police is using a windows-1252 charset as well. That probably explains why the like and dislike icons were corrupted when you first installed FAE. Think

I've opened a new issue on Github for this : https://github.com/SethClydesdale/forumactif-edge/issues/35


EDIT :
@Milouze14 would it be possible for you to lend me a test account ? All my forums are UTF-8, so I can't really test the Encoding function.
avatar
Milouze14

Title :
Gender : Male
Age : 51
Posts : 76
Points : 418
Reputation : 22
Location : French Vendée
Language : French
Browser : Browser : Mozilla Firefox Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile http://www.milouze14.com/

PostMilouze14 on Sat 08 Apr 2017, 01:19

Hello @Ange Tuteur Tuteur,

Thank you very much my friend, for the test account I send you all this in private messenger.

This is not really a bug, but I am forced to type all the special characters with each update Very Happy .

a++
avatar
Dr Jay

Title :
Power of Youth!
Gender : Male
Posts : 153
Points : 514
Reputation : 33
Location : USA
Language : English (Native)
Browser : Browser : Mozilla Firefox Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile http://www.geekpolice.net

PostDr Jay on Sat 08 Apr 2017, 05:18

@Ange Tuteur wrote:@Dr Jay I think Geek Police is using a windows-1252 charset as well. That probably explains why the like and dislike icons were corrupted when you first installed FAE. Think

Well, how to detect the charset in the first place, which is what I determined as well when we were thinking over the possible solutions. Are you thinking on the way to convert the charset over from Windows-1252 to UTF-8? I sure wish Unicode was usable.

--------

~Dr Jay
avatar
Ange Tuteur
Administrator
Title :
Coffee Addict
Gender : Male
Age : 21
Posts : 4675
Points : 9689
Reputation : 2331
Location : Macungie, PA
Language : EN10, FR5
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile https://github.com/SethClydesdale https://twitter.com/sethc1995

PostAnge Tuteur on Sat 08 Apr 2017, 11:07

@Milouze14 wrote:Hello @Ange Tuteur Tuteur,

Thank you very much my friend, for the test account I send you all this in private messenger.

This is not really a bug, but I am forced to type all the special characters with each update Very Happy .

a++
No problem, and thanks ! ^^ I'll plan to look into this issue on Monday. Wink

hehe it's definitely a bug in my eyes ; anything that doesn't function as expected is. Razz

@Dr Jay wrote:Well, how to detect the charset in the first place, which is what I determined as well when we were thinking over the possible solutions. Are you thinking on the way to convert the charset over from Windows-1252 to UTF-8? I sure wish Unicode was usable.
Hmm.. it IS possible, to a degree, but it'd most likely require going over every single editable piece of text and converting it to UTF-8. I know or I think there's a way to do this over PHP, but I guess Forumotion would rather leave things as is. As they say... if it's not broken, don't fix it. Razz

But anyways, I'll probably add a small condition in the AJAX functions that checks the charset of the forum, and if it's a non-UTF-8 charset we'll use the Encoding function to encode the characters. You can usually check the charset of a website by writing
Code:
document.charset
or
Code:
document.characterSet
in the console, or just searching for the charset meta tag in the <head> section. Wink
avatar
Ange Tuteur
Administrator
Title :
Coffee Addict
Gender : Male
Age : 21
Posts : 4675
Points : 9689
Reputation : 2331
Location : Macungie, PA
Language : EN10, FR5
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile https://github.com/SethClydesdale https://twitter.com/sethc1995

PostAnge Tuteur on Mon 10 Apr 2017, 14:08

@Milouze14 I've made some tests and should have everything setup so that any characters sent over AJAX on non-utf8 forums are encoded beforehand. Before I send out any major updates, I just want to confirm that everything works as expected. Can you try the following on your forum when you're free ?

  1. Backup your ALL.JS file by copying and pasting the contents to a text document on your PC.
  2. Go to FAE CP > Plugin Management > Theme Selector Options.
  3. Click "New Theme" to add a new theme.
  4. Make the new theme's name "á é ç ö  ".
  5. Click "Update Plugins" to save the new theme to JS Codes Management.

Once this is done, check if the theme name remains as you set it, both in the theme selector and theme editor.



Thanks for your help. Smile
avatar
Milouze14

Title :
Gender : Male
Age : 51
Posts : 76
Points : 418
Reputation : 22
Location : French Vendée
Language : French
Browser : Browser : Mozilla Firefox Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile http://www.milouze14.com/

PostMilouze14 on Mon 10 Apr 2017, 14:23

Hello @Ange Tuteur ,
Your procedure completely put my forum in a catastrophic state.
Thank you for doing something my friend
avatar
Ange Tuteur
Administrator
Title :
Coffee Addict
Gender : Male
Age : 21
Posts : 4675
Points : 9689
Reputation : 2331
Location : Macungie, PA
Language : EN10, FR5
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile https://github.com/SethClydesdale https://twitter.com/sethc1995

PostAnge Tuteur on Mon 10 Apr 2017, 14:38

Sorry 'bout that, I'm going to take a look over it again and see what can be done. I've disabled the encoder for now, thanks for testing it. Salute
avatar
Milouze14

Title :
Gender : Male
Age : 51
Posts : 76
Points : 418
Reputation : 22
Location : French Vendée
Language : French
Browser : Browser : Mozilla Firefox Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile http://www.milouze14.com/

PostMilouze14 on Mon 10 Apr 2017, 14:42

Most of the main templates were purely deleted by codes unknown to me (unknown characters),
I will have to find an alternative to have a forum that looks like something.

Thanks

a++
avatar
Ange Tuteur
Administrator
Title :
Coffee Addict
Gender : Male
Age : 21
Posts : 4675
Points : 9689
Reputation : 2331
Location : Macungie, PA
Language : EN10, FR5
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile https://github.com/SethClydesdale https://twitter.com/sethc1995

PostAnge Tuteur on Mon 10 Apr 2017, 16:57

That's really weird since plugin management only updates ALL.JS. Still, I apologize for the mess ; it's on me for not getting it right. I honestly don't want to put you through that again, but my options are limited in regards to testing this.. Think I've made some revisions to the encoding function which should work properly now, but nothing is final until it has been put to the test. Would you be willing to help test it for me, one more time ?

I haven't enabled it yet ; I'm only going to enable it on specific domains to avoid large-scale issues.
avatar
Milouze14

Title :
Gender : Male
Age : 51
Posts : 76
Points : 418
Reputation : 22
Location : French Vendée
Language : French
Browser : Browser : Mozilla Firefox Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile http://www.milouze14.com/

PostMilouze14 on Mon 10 Apr 2017, 21:49

Hello @Ange Tuteur ,
I will watch my friend tonight, but already last night I did not have in the theme selector what you show me on this capture:


you be willing to help test it for me, one more time ?

I would be available around 16:00 .

Thank you and good day Wink .
a++



avatar
Ange Tuteur
Administrator
Title :
Coffee Addict
Gender : Male
Age : 21
Posts : 4675
Points : 9689
Reputation : 2331
Location : Macungie, PA
Language : EN10, FR5
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile https://github.com/SethClydesdale https://twitter.com/sethc1995

PostAnge Tuteur on Tue 11 Apr 2017, 10:28

@Milouze14 Alright, thanks ! ^^ I've enabled the Encoder on your forum temporarily ; it should be showing a maintenance message. When you get the chance, follow the steps below.

  1. Go to Admin Panel > Modules > JS Codes management > ALL.JS and copy the contents to a text document on your PC. Just to be safe.
  2. Go to FAE Control Panel > Plugin Management > Add a new theme
  3. Make sure that you put these special characters as the theme's name : "á é ç ö  "
  4. Click "Update Plugins" to save the new theme to JS Codes Management.



When the plugins have been updated, check to make sure that everything is working correctly. If the theme name remains "á é ç ö  " it means the test was a success. If any issues let me know.
avatar
Milouze14

Title :
Gender : Male
Age : 51
Posts : 76
Points : 418
Reputation : 22
Location : French Vendée
Language : French
Browser : Browser : Mozilla Firefox Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile http://www.milouze14.com/

PostMilouze14 on Tue 11 Apr 2017, 10:44

cheers cheers cheers @Ange Tuteur ,


You are really impressive my friend,
Everything works perfectly.
Thank you very much for your responsiveness and I hope this will serve other members with UTF-8 Wink .

a++




avatar
Ange Tuteur
Administrator
Title :
Coffee Addict
Gender : Male
Age : 21
Posts : 4675
Points : 9689
Reputation : 2331
Location : Macungie, PA
Language : EN10, FR5
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile https://github.com/SethClydesdale https://twitter.com/sethc1995

PostAnge Tuteur on Tue 11 Apr 2017, 11:03

@Milouze14 that's great to hear ! * DEEP SIGH OF RELIEF * I'm honestly relieved to hear you say that haha. After the first problem, I looked at the script I wrote for the English Support forum again and noticed that I sent the data via a query string, instead of an object. Yesterday I only encoded the JS content in the object instead of the WHOLE object, which was the issue.. Face palm So when Encoding the data to send over AJAX this is how it looks now depending on your forum's encoding :

UTF-8 on the Left and NON-UTF-8 on the Right.


I'll be enabling the Encoder for non-utf8 forums very soon. Of course if any issues arise, just let me know and I'll be on 'em. Rambo

Thanks a lot for helping me test this implementation, and once again for bringing the issue to my attention ! I'm grateful for your help Very good
avatar
Milouze14

Title :
Gender : Male
Age : 51
Posts : 76
Points : 418
Reputation : 22
Location : French Vendée
Language : French
Browser : Browser : Mozilla Firefox Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile http://www.milouze14.com/

PostMilouze14 on Tue 11 Apr 2017, 11:23

Effectively in non-UTF-8, the template overall_header had been totally replaced by strange sequences of characters, since everything is returned in the order my friend.
If I have any worries, I'll come back to you Wink
avatar
Milouze14

Title :
Gender : Male
Age : 51
Posts : 76
Points : 418
Reputation : 22
Location : French Vendée
Language : French
Browser : Browser : Mozilla Firefox Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile http://www.milouze14.com/

PostMilouze14 on Fri 14 Apr 2017, 13:31

Hello @Ange Tuteur ,

After the last update (v1.2.3.),
Everything went well my friend, thank you again for all the work done. cheers cheers .

a++
avatar
Ange Tuteur
Administrator
Title :
Coffee Addict
Gender : Male
Age : 21
Posts : 4675
Points : 9689
Reputation : 2331
Location : Macungie, PA
Language : EN10, FR5
Browser : Browser : Brave Forum Version : Forum Version : Forumactif Edge
Awards :
View all awards
View user profile https://github.com/SethClydesdale https://twitter.com/sethc1995

PostAnge Tuteur on Fri 14 Apr 2017, 14:27

@Milouze14 Thanks for letting me know ; it's a relief to hear ! Mr. Green

Have a great weekend. Very good

View previous topic View next topic Back to top

Create an account or log in to leave a reply

You need to be a member in order to leave a reply.

Create an account

Join our community by creating a new account. It's easy!


Create a new account

Log in

Already have an account? No problem, log in here.


Log in

 
Permissions in this forum:
You cannot reply to topics in this forum